[LocalNet] Add option to turn on/off delve - Githubissues

pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev

MIT License

15 stars 7 forks source link

[LocalNet] Add option to turn on/off delve #485

Closed okdas closed 2 months ago

okdas commented 2 months ago

Summary

Allows to turn delve on and off using localnet_config.yaml.

The related changes to helm charts were added in this PR - new functionality is optional and turned off by default, so I felt confident to merge.

Type of change

Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

Documentation changes (only if making doc changes)

[ ] make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

[x] Unit Tests: make go_develop_and_test
[x] LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

[ ] I have tested my changes using the available tooling
[ ] I have commented my code
[ ] I have performed a self-review of my own code; both comments & source code
[ ] I create and reference any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable

okdas commented 2 months ago

@Olshansk I'm going to merge it, please lmk if you have any feedback. :)