[RelayMiner] Support https backend urls - Githubissues

pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev

MIT License

15 stars 6 forks source link

[RelayMiner] Support https backend urls #507

Closed red-0ne closed 2 months ago

red-0ne commented 2 months ago

Summary

Make RelayMiner support forwarding relay requests to https backends.

It infers the protocol to use from the backend_url schema and constructs the appropriate client.

Updates the RelayMiner config parser and make it accept https backend urls.

Issue

The RelayMiner is not capable of forwarding relay requests to https backend_urls, which is a quite widespread setup among node runners.

https://github.com/pokt-network/poktroll/issues/499#issuecomment-2078487122

Type of change

Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

Local Testing (only if making code changes)

[x] Unit Tests: make go_develop_and_test
[x] LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

[x] I have tested my changes using the available tooling
[ ] I have commented my code
[x] I have performed a self-review of my own code; both comments & source code
[ ] I create and reference any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable