[SDK] Track pb.go files

[red-0ne]

Summary

This PR adds tracking to .pb.go generated files and removes the corresponding entry from .gitignore

Issue

In order to use the generated types corresponding to proktroll protobuf definitions from external repositories, the generated .pb.go files need to be added to the repo.

This is currently the only viable solution to decouple the SDK and extract it to its own repo.

• 510

Type of change

Select one or more:

• [x] New feature, functionality or library
• [ ] Bug fix
• [ ] Code health or cleanup
• [ ] Documentation
• [ ] Other (specify)

Testing

Documentation changes (only if making doc changes)

• [ ] make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

• [ ] Unit Tests: make go_develop_and_test
• [ ] LocalNet E2E Tests: make test_e2e
• See quickstart guide for instructions

PR Testing (only if making code changes)

• [ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
  • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
  • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
  • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

• [x] I have tested my changes using the available tooling
• [ ] I have commented my code
• [x] I have performed a self-review of my own code; both comments & source code
• [ ] I create and reference any new tickets, if applicable
• [ ] I have left TODOs throughout the codebase, if applicable

[okdas]

@Olshansk I agree. If we remove proto_regen from CI, we will achieve reproducible builds. Let's remove this step.

We can introduce another CI step that will fail if there's a difference between the committed pb files and the protobufs generated by CI. This way, we can catch situations where .proto files were changed but .pb.go files were not updated (or were updated incorrectly).

Does that make sense? If so, I'll create a ticket to work on that.

[Olshansk]

We can introduce another CI step that will fail if there's a difference between the committed pb files and the protobufs generated by CI

@red-0ne let's add a TODO_IMPROVE for ☝️ but seems overkill for now

[github-actions[bot]]

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

[red-0ne]

Reviewdog checks are failing due to big diff but unit and e2e tests are passing.

Merging