pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[On-chain] scaffold: module shared #545

Closed bryanchriswhite closed 1 month ago

bryanchriswhite commented 1 month ago

Summary

Scaffolds a new shared module. This module has no module dependencies and is intended to hold parameters & algorithms which are dependencies of multiple other modules (e.g. session & application both depend on NumBlocksPerSession).

This branch is the result of running ignite scaffold module share on its base. No changes are made to scaffold output, except those necessary to satisfy CI.

Issue

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist


:rocket: This description was created by Ellipsis for commit 4acef34e46ccec129f9d8100483bd72f010ee9e4

Summary:

Introduces a new shared module to manage parameters and dependencies shared across multiple modules, with support for parameter updates and necessary tests.

Key points:


Generated with :heart: by ellipsis.dev

github-actions[bot] commented 1 month ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.