pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[AppGateServer] Implement AppGateServer using ShannonSDK #554

Closed red-0ne closed 3 weeks ago

red-0ne commented 1 month ago

Summary

Re-implement AppGateServer using ShannonSDK [1] module.

[1] https://github.com/pokt-network/shannon-sdk

Issue

image

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist

ellipsis-dev[bot] commented 1 month ago

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev

red-0ne commented 1 month ago

@Olshansk , Updated this PR to reflect the change on shannon-sdk that is no longer relying on method or headers, since it now assumes that the whole request (not only the body is serialized).

This led to change the way we are transmitting the upstream request to the RelayMiner which needs to use the same headers and methods.

A SerializableHttp{Request,Response} structs have been added with their corresponding codecs to embed the bytes representation of http.{Request,Response} intoRelay{Request/Response}`s.

One last point, even if unrelated to this feature (while it is to the codec). Is the proper handling of upstream request -> appgateserver -> backend_url paths and query strings.

github-actions[bot] commented 3 weeks ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 554)) Grafana network dashboard for devnet-issue-{issue-id}