pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[Application] Refactor app module to fetch on-chain params #555

Closed bryanchriswhite closed 1 month ago

bryanchriswhite commented 1 month ago

Summary

Refactor the application module to remove all usage of the NumBlocksPerSession stand-in constant, in favor of fetching the on-chain param. This involves adding the shared module as a dependency.

Issue

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist

github-actions[bot] commented 1 month ago

The image is going to be pushed after the next commit. You can use make trigger_ci to push an empty commit. If you also want to run an E2E test, please add devnet-test-e2e label.

github-actions[bot] commented 1 month ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

ellipsis-dev[bot] commented 1 month ago

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at help@ellipsis.dev

bryanchriswhite commented 1 month ago

:rotating_light: Do not delete branch until #556's base has changed! :rotating_light: