pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[On-chain] feat: add `proof_window_open_offset_blocks` as `shared` module parameter #569

Closed bryanchriswhite closed 3 weeks ago

bryanchriswhite commented 1 month ago

Summary

Adds proof_window_open_offset_blocks parameter to the shared module

Issue

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist

github-actions[bot] commented 1 month ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 569)) Grafana network dashboard for devnet-issue-{issue-id}

bryanchriswhite commented 4 weeks ago

Not a request but a question:

  1. Why no Makefile target?

Added in fe30755.

  1. Do we have a unit test for failing edge cases elsewhere? If so, we should have it here too

@Olshansk can you elaborate on what you mean here?

The first thing that msgServer#UpdateParams() does is call MsgUpdateParam#ValdiateBasic(), which has almost complete coverage:

image

Doesn't cover MsgUpdateParam#AsType == nil case.

The rest of the un-covered (sad) paths in msgServer#UpdateParam() are redundant as they would only occur if MsgUpdateParam#ValidateBasic() returned an error, which we're checking for initially:

image

Doesn't cover redundant sad paths.