Closed bryanchriswhite closed 3 weeks ago
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.
You may need to run make trigger_ci
to submit an empty commit that'll trigger the tests.
GCP workloads (requires changing the namespace to 569)) Grafana network dashboard for devnet-issue-{issue-id}
Not a request but a question:
- Why no Makefile target?
Added in fe30755.
- Do we have a unit test for failing edge cases elsewhere? If so, we should have it here too
@Olshansk can you elaborate on what you mean here?
The first thing that msgServer#UpdateParams()
does is call MsgUpdateParam#ValdiateBasic()
, which has almost complete coverage:
Doesn't cover
MsgUpdateParam#AsType == nil
case.
The rest of the un-covered (sad) paths in msgServer#UpdateParam()
are redundant as they would only occur if MsgUpdateParam#ValidateBasic()
returned an error, which we're checking for initially:
Doesn't cover redundant sad paths.
Summary
Adds
proof_window_open_offset_blocks
parameter to theshared
moduleIssue
516
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist