[Relay Mining] Foundation for integration test helpers + start integrating Relay Mining into EndBlocker - Githubissues

pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev

MIT License

15 stars 6 forks source link

[Relay Mining] Foundation for integration test helpers + start integrating Relay Mining into EndBlocker #571

Closed Olshansk closed 3 weeks ago

Olshansk commented 1 month ago

Summary

Core changes:

Calling UpdateRelayMiningDifficulty in the tokenomics EndBlockers
Introduce the infra & helpers for integration tests to be used heavily in the next PRs
Capture & return a ServiceToRelayCount map when settling claims

Misc changes:

Started moving some fixture generation helpers into a shared package
Minor Makefile cleanup
Reoder some imports
Rename s/errorsmod/sdkerrors

Up next:

Update SMT to store the number of leaves/relays (not just compute units)
Full integration tests + E2E tests
Emit events
Update our grafana dashhboards to see how difficulty looks next to resource usage
Integrate with stress testing

Issue

542

Type of change

Select one or more:

[x] New feature, functionality or library
[ ] Bug fix
[ ] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

Documentation changes (only if making doc changes)

[ ] make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

[x] Unit Tests: make go_develop_and_test
[ ] LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

[ ] I have tested my changes using the available tooling
[x] I have commented my code
[x] I have performed a self-review of my own code; both comments & source code
[x] I create and reference any new tickets, if applicable
[x] I have left TODOs throughout the codebase, if applicable

Olshansk commented 3 weeks ago

@bryanchriswhite I did the following:

Tended to the comments you left in #574
Tended to the comments you left here
Merged with main -> found bugs
Fixed a few things
Left a few more TODO_IN_THIS_PR. In particular, can you please see the discussion in x/shared/session.go.

cc @red-0ne as an optional reviewer