[Testutils] refactor: keeper testutils - Githubissues

pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using the Cosmos SDK

MIT License

15 stars 8 forks source link

[Testutils] refactor: keeper testutils #602

Closed bryanchriswhite closed 4 months ago

bryanchriswhite commented 4 months ago

Summary

Refactors WithBlockHeight() and WithBlockHash() ProofKeepersOpt functions to be in terms of a new genericOptionFunc so that they can be reused between ProofModuleKeepers and TokenomicsModuleKeepers integration environments.
Moves common helpers to a new package in testutil/keeper/common.

Issue

579

Type of change

Select one or more:

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

Documentation changes (only if making doc changes)

[ ] make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

[ ] Unit Tests: make go_develop_and_test
[ ] LocalNet E2E Tests: make test_e2e
See quickstart guide for instructions

PR Testing (only if making code changes)

[ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
- THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
- Optionally run make trigger_ci if you want to re-trigger tests without any code changes
- If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

[ ] I have tested my changes using the available tooling
[ ] I have commented my code
[ ] I have performed a self-review of my own code; both comments & source code
[ ] I create and reference any new tickets, if applicable
[ ] I have left TODOs throughout the codebase, if applicable

bryanchriswhite commented 4 months ago

I'm converting this back to a draft for now, as I'm starting to question the necessity. Please standby on this one. I'll either close it or re-request review when ready.