pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[Tokenomics] feat: add probabilistic proof requirement case #604

Closed bryanchriswhite closed 1 week ago

bryanchriswhite commented 2 weeks ago

Summary

Add the probabilistic proof requirement case while settling.

Issue

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist

github-actions[bot] commented 2 weeks ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 604)) Grafana network dashboard for devnet-issue-{issue-id}

github-actions[bot] commented 2 weeks ago

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

bryanchriswhite commented 2 weeks ago

@Olshansk this item is still outstanding:

image

okdas commented 1 week ago

@bryanchriswhite I'm going to merge in the main branch (using GitHub "Update branch" button) to resolve the e2e test issue.

okdas commented 1 week ago

Just one flaky test it seems:

Screenshot 2024-06-18 at 12 30 55 PM

@bryanchriswhite assuming you're fine with the changes/state of the PR, is there anything else blocking this PR from being merged?

bryanchriswhite commented 1 week ago

Thank you @okdas! :heart:

bryanchriswhite commented 1 week ago

:rotating_light: Do not delete this branch until #605 changes bases! :rotating_light: