[TODOs] chore: cleanup validate session ID TODOs

[bryanchriswhite]

Summary

• Ensure that session IDs aren't empty.
• Simplify session hydration helpers.

Issue

• 586

Type of change

Select one or more:

• [ ] New feature, functionality or library
• [ ] Bug fix
• [x] Code health or cleanup
• [ ] Documentation
• [ ] Other (specify)

Testing

Documentation changes (only if making doc changes)

• [ ] make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

• [ ] Unit Tests: make go_develop_and_test
• [ ] LocalNet E2E Tests: make test_e2e
• See quickstart guide for instructions

PR Testing (only if making code changes)

• [ ] DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
  • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
  • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
  • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

• [ ] I have tested my changes using the available tooling
• [ ] I have commented my code
• [x] I have performed a self-review of my own code; both comments & source code
• [ ] I create and reference any new tickets, if applicable
• [ ] I have left TODOs throughout the codebase, if applicable

[github-actions[bot]]

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 608)) Grafana network dashboard for devnet-issue-{issue-id}

[github-actions[bot]]

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

[bryanchriswhite]

E2E tests are passing locally but failed to run in CI: