pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[Relay Mining] Emit events and refactor test helpers #610

Closed Olshansk closed 1 week ago

Olshansk commented 2 weeks ago

Summary

Issue

Type of change

Select one or more:

Testing

Sanity Checklist

Olshansk commented 1 week ago

@bryanchriswhite @red-0ne Few things to note in this PR:

  1. The actual business logic was short & simple
  2. A lot of work went into making the integration test work
  3. A lot of improvements were made to the utilities in a way that existing ones were reused & refactored
  4. @bryanchriswhite Special request - please make a mental note of all the TODOs in case you come up with better ideas in the future
  5. @red-0ne Special request - see the TODOs in the code related to the telemetry. I will ask you to implement it on my behalf due to time limitations & because I'd like to present it at EthCC
Olshansk commented 1 week ago

@bryanchriswhite @red-0ne LOVE the comments on this! Ready for another review but also beginning to look much better after all your suggestions 🚀

github-actions[bot] commented 1 week ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 610)) Grafana network dashboard for devnet-issue-{issue-id}