pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[Code Health] refactor: block query client interface #616

Closed bryanchriswhite closed 6 days ago

bryanchriswhite commented 1 week ago

Summary

Define a new interface which is a subset of cometclient.CometRPC and only contains members that poktroll depends on.

Issue

We were depending on a cometbft interface which was much larger than we need. This came while working on #402 in an integration test. Defining our own interface for this purpose is more "SOLID".

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist

github-actions[bot] commented 6 days ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 616)) Grafana network dashboard for devnet-issue-{issue-id}

github-actions[bot] commented 6 days ago

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

bryanchriswhite commented 6 days ago

E2E tests passed locally but failed to run in CI: image