pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using Rollkit.dev
MIT License
15 stars 6 forks source link

[Code Health] refactor: tx hash encoding #617

Closed bryanchriswhite closed 4 days ago

bryanchriswhite commented 1 week ago

Summary

Promotes some functions we use to normalize transaction hash strings to their own package to improve reusability.

Issue

While these functions ended up not applying to #402, I think the resulting of this refactor is still an improvement to the codebase.

Type of change

Select one or more:

Testing

Documentation changes (only if making doc changes)

Local Testing (only if making code changes)

PR Testing (only if making code changes)

Sanity Checklist

github-actions[bot] commented 6 days ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 617)) Grafana network dashboard for devnet-issue-{issue-id}

github-actions[bot] commented 6 days ago

The image is going to be pushed after the next commit.

You can use make trigger_ci to push an empty commit.

If you also want to run E2E tests, please add devnet-test-e2e label.

bryanchriswhite commented 4 days ago

E2E tests passed locally but failed to run in CI across multiple commits: image