Closed red-0ne closed 4 months ago
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.
You may need to run make trigger_ci
to submit an empty commit that'll trigger the tests.
GCP workloads (requires changing the namespace to 634)) Grafana network dashboard for devnet-issue-{issue-id}
Summary
Add a static
GetRingAddressesAtSessionEndHeight
function that receives asessionEndBlockHeight
instead of an arbitraryblockHeight
.Make
GetRingAddressesAtBlock
useGetRingAddressesAtSessionEndHeight
.Issue
The static
GetRingAddressesAtBlock
depends on theshared
package to getsessionEndBlockHeight
out of an arbitraryblockHeight
andsharedparams
. This implies that the environment usingGetRingAddressesBlock
needs to have asharedClient
dependency.The
shannon-sdk
needs to get the the application's ring to sign aRelayRequest
and is currently needing asharedClient
and an additional request just for the sake of getting asessionEndBlockHeight
. While this one is available on the fetched session's meta.In order to avoid pulling this dependency or reimplementing ring generation.
GetRingAddressesAtSessionEndHeight
accepts asessionEndHeight
that the caller could retrieve by other means than querying thesharedParams
module.Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist