Closed bryanchriswhite closed 2 days ago
The update refactors the actorLoadTestIncrementPlans
struct in the relays_stress_helpers_test.go
file by modifying how total duration blocks are calculated. Instead of a direct calculation using sharedParams.GetGracePeriodEndOffsetBlocks()
and sharedParams.GetNumBlocksPerSession()
, the new implementation uses the shared.GetProofWindowCloseHeight
function, streamlining and centralizing the calculation logic.
File Path | Change Summary |
---|---|
load-testing/tests/relays_stress_helpers_test.go |
Refactored calculation of total duration blocks in actorLoadTestIncrementPlans to use shared.GetProofWindowCloseHeight . |
.../poktroll/x/shared |
New import added for shared package utility. |
In code's realm, a change does glide,
Refactor swift, in struct’s stride.
Total blocks now rightly shown,
Central logic brightly grown.
Shared path we now delight,
Proof's close height, clear and bright.
🌟🔧 A tweak so wise, the code’s new might! 🚀
[!TIP]
Early access features: enabled
We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Closing. This is wrong and we implemented a better fix in @red-0ne's forthcoming PR branch.
Summary
Fixes the test duration calculation for the relays stress test. This reduces (but does not seem to completely eliminate) the flakiness of the
TheCorrectPairsCountOfClaimAndProofMessagesShouldBeCommittedOnchain
assertion step.Issue
Observation made while working on #643.
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist
Summary by CodeRabbit