Open bryanchriswhite opened 2 days ago
[!WARNING]
Rate limit exceeded
@bryanchriswhite has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 30 seconds before requesting another review.
How to resolve this issue?
After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.How do rate limits work?
CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.Commits
Files that changed from the base of the PR and between 1ee0cdfc54655c0e5e9ba39e68aa6427228c4e60 and ffbe37713e240f742e13dc4c5e0ee17468859c65.
The recent changes introduce a significant feature to the replayObservable
struct: the SubscribeFromLatestBufferedOffset
method. This addition permits observers to start receiving values from a specified offset within the replay buffer, enhancing flexibility and control. New test cases verify this functionality, ensuring various scenarios are handled efficiently. Additionally, the ReplayObservable
interface now incorporates this method, reflecting the broader capability.
Files/Paths | Change Summary |
---|---|
pkg/observable/channel/replay.go |
Added SubscribeFromLatestBufferedOffset method to replayObservable struct and updated Subscribe method logic. |
pkg/observable/channel/replay_test.go |
Introduced new test TestReplayObservable_SubscribeFromLatestBufferedOffset and helper function accumulateValues . |
pkg/observable/interface.go |
Updated ReplayObservable interface to include SubscribeFromLatestBufferedOffset method. |
In channels deep where buffers flow,
A new method now you know.
From latest offsets values stream,
Observers join the flowing dream.
Through tests and codes it shines so bright,
Subscribing now is such a delight.
🐰✨ Happy coding day and night!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.
You may need to run make trigger_ci
to submit an empty commit that'll trigger the tests.
GCP workloads (requires changing the namespace to 647)) Grafana network dashboard for devnet-issue-{issue-id}
Summary
Add
ReplayObservable#SubscribeFromLatestBufferedOffset()
to support finer control over replay observable subscriptions.Issue
553
Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist
Summary by CodeRabbit
New Features
Tests