[Code Health] Mitigate import cycles in pkg/client

bryanchriswhite commented 4 months ago

Objective

Mitigate looming dependency cycles in pkg/client.

Origin Document

See: https://github.com/pokt-network/poktroll/pull/655#discussion_r1666476343.

See: https://github.com/pokt-network/poktroll/pull/662#discussion_r1668464237

Goals

Enumerate potential long-term & general solutions.
Resolve tension caused by current import cycle workaround.
Systematically prevent future import cycles in pkg/client.

Deliverables

[ ] A comment or link to a notion page which outlines the possible solutions, their pros and cons.
[ ] One or more PRs which implement the chosen solution

Non-goals / Non-deliverables

Unrelated refactoring or re-organization.

General deliverables

[ ] Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
[ ] Testing: Add new tests (unit and/or E2E) to the test suite.
[ ] Makefile: Add new targets to the Makefile to make the new functionality easier to use.
[ ] Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @bryanchriswhite Co-Owners: @Olshansk

Olshansk commented 3 months ago

@bryanchriswhite Is this still relevant or can we close it out?

red-0ne commented 3 months ago

@bryanchriswhite Is this still relevant or can we close it out?

It is still relevant but depends on the outcome of https://github.com/pokt-network/poktroll/pull/697#issuecomment-2249018956 to move forward.

Olshansk commented 3 months ago

This does not seem urgent w.r.t to all the other feature work. Please lmk if this is a Shanno Beta TestNet Launch action item or a quality of life that can be done post mainnet.

red-0ne commented 2 months ago

Closing as per #697

pokt-network / poktroll