pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using the Cosmos SDK
MIT License
16 stars 10 forks source link

[Foundation] Add gas fees #794

Open Olshansk opened 2 months ago

Olshansk commented 2 months ago

Objective

Add transaction/gas fees to poktroll.

Origin Document

https://docs.cosmos.network/main/learn/beginner/gas-fees

https://www.notion.so/buildwithgrove/Proof-submission-cost-Tx-fee-vs-Spend-coins-044bcab72c1d4aef8dba523bd9bdf42d?pvs=4

Screenshot 2024-09-04 at 3 03 48 PM

Screenshot 2024-09-04 at 3 01 53 PM

Goals

Deliverables

Non-goals / Non-deliverables

General deliverables


Creator: @Olshansk Co-Owners: @okdas

okdas commented 2 months ago

@Olshansk I've added the gas fees in #768. They're not constant, though. I can look into that to see if constant fees can be easily configured.

okdas commented 2 months ago

I flipped the config temporarily in TestNet, and

Will take a look at both when I start working on the ticket.

Olshansk commented 2 months ago

@okdas Once you take a look at it, let's go with CLI defaults (if it's possible) and just document the flag in the user guide in one spot.

okdas commented 2 months ago

Related doc: https://www.notion.so/buildwithgrove/Proof-submission-cost-Tx-fee-vs-Spend-coins-044bcab72c1d4aef8dba523bd9bdf42d?pvs=4

okdas commented 5 days ago

We've decided we are not going to add a constant gas fee. However, we still need to adjust minimum-gas-prices on our networks to make sure we don't miss anything gas related. Will prioritize this in preparation for beta testnet and #925.