pokt-network / poktroll

The official Shannon upgrade implementation of the Pocket Network Protocol implemented using the Cosmos SDK
MIT License
15 stars 8 forks source link

[Gateway] Enforce minimum stake when staking #843

Closed bryanchriswhite closed 1 month ago

bryanchriswhite commented 1 month ago

Summary

  1. Adds minimum stake validation to the gateway stake message handler (i.e. total stake must be >= minimum stake).
  2. Updates error returns in the same handler to ensure all error paths return appropriate gRPC status errors.
  3. Replaces some warn and error level logs with info level, which I believe is more appropriate (until we have a practical debug level, at which point they should become debug logs).

Dependencies

Dependents

Issue

Gateway staking min stake validation.

Type of change

Select one or more from the following:

Testing

Sanity Checklist

github-actions[bot] commented 1 month ago

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 843)) Grafana network dashboard for devnet-issue-843