feat: Add support for `cosmos/ics23` `NonMembershipProof` types - Githubissues

pokt-network / smt

A Go library that implements a Sparse Merkle Trie for a key-value map.

https://pkg.go.dev/github.com/pokt-network/smt

Other

16 stars 4 forks source link

feat: Add support for `cosmos/ics23` `NonMembershipProof` types #16

Open h5law opened 1 year ago

h5law commented 1 year ago

Objective

Add support for the "range based" non-membership proof types used in the cosmos/ics23 library.

Screenshot 2023-07-18 at 10 00 09

Origin Document

cosmos/ics23 issue #152

Goals

Add a new ProveExclusion function that can traverse the tree and looking for the key we aim to prove, once it has found a leaf it should collect the adjecent leaves and produce a proof for them.
- Reference the JMT's implementation
Add a function to convert SparseMerkleProof objects into the relevent ics23.CommitmentProof types
- See: pocket/ibc/store/proofs_ics23.go

Deliverable

[ ] SMT proof type conversion function to ics23 proof type
[ ] Prove nonmembership in accordance with the ics23 repo

Non-goals / Non-deliverables

Change existing proof logic

General issue deliverables

[ ] Update any relevant README(s)
[ ] Add or update any relevant or supporting mermaid diagrams

Testing Methodology

[ ] Task specific tests or benchmarks: go test ...
[ ] New tests or benchmarks: go test ...
[ ] All tests: go test -v

Creator: @h5law Co-Owners: @h5law

h5law commented 8 months ago

This would require we index the tree, see [1] as a reference on how this works. But is currently not in focus or planned on being implemented.

[1] https://docs.aztec.network/concepts/advanced/data_structures/indexed_merkle_tree