[Code Health] refactor: SMST#Root(), #Sum(), & #Count() - Githubissues

pokt-network / smt

A Go library that implements a Sparse Merkle Trie for a key-value map.

https://pkg.go.dev/github.com/pokt-network/smt

Other

16 stars 4 forks source link

[Code Health] refactor: SMST#Root(), #Sum(), & #Count() #51

Closed bryanchriswhite closed 3 months ago

bryanchriswhite commented 3 months ago

Summary

Add:
- MerkleSumRoot
- SMST#MustCount()
- SMST#MustSum()
- MerkleSumRoot#MustCount()
- MerkleSumRoot#DigestSize()
- MerkleSumRoot#HasDigestSize()
Refactor:
- SMST#Root() to return MerkleSumRoot

Human Summary

AI Summary

reviewpad:summary

Issue

Fixes https://github.com/pokt-network/poktroll/issues/584

Type of change

Please mark the relevant option(s):

[ ] New feature, functionality or library
[ ] Bug fix
[x] Code health or cleanup
[ ] Documentation
[ ] Other (specify)

Testing

[ ] Run all unit tests: make test_all
[ ] Run all/relevant benchmarks (if optimising): make benchmark_{all | suite name}

Required Checklist

[ ] I have tested my changes using the available tooling
[ ] I have performed a self-review of my own code
[ ] I have commented my code (godoc format comments see: tip.golang.org/doc/comment)

If Applicable Checklist

[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have updated any relevant README(s)/documentation and left TODOs throughout the codebase
[ ] Add or update any relevant or supporting mermaid diagrams