search

pokt-network / wallet

A simple web wallet to handle your Pocket Network accounts.
wallet-three-orpin.vercel.app
MIT License
8 stars 14 forks source link

Non-custodial #363

Closed PseudoMera closed 2 years ago

PseudoMera commented 2 years ago

With non custodial we needed to update two things here to make it work:

  1. Unstake
  2. Unjail

The way these things were setup you could only unstake/unjail the account you are using (the one you are "logged in" for). This PR allows users to specify the address of the account/node before they submit these txs.

This also adds some checks to make sure the account that is submitting the tx can actually make them and some other minor "improvements".

height[bot] commented 2 years ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

kutoft commented 2 years ago

@PseudoMera : code in general looks fine. A few places I could give feedback but no big issues. However I am having a hard time understanding if the code you wrote actually achieved what you wanted it to. Can you update the description to talk about what you needed to do and what you ended up doing. Thanks