pokt-network / wallet

A simple web wallet to handle your Pocket Network accounts.
wallet-three-orpin.vercel.app
MIT License
8 stars 14 forks source link

Changes for Ledger #421

Closed ArtSabintsev closed 1 year ago

ArtSabintsev commented 1 year ago

From Nate at Obsidian Systems via Victor from Ledger:

Use newer logo on import account

Replace:

Screenshot_2023-06-08_at_3 31 45_PM

With these two:

Screenshot_2023-06-08_at_3 33 43_PM Screenshot_2023-06-08_at_3 33 50_PM

Add "Verify address" button

There are two address related commands that the Ledger app respond to. https://github.com/obsidiansystems/ledger-app-pocket/blob/develop/docs/apdu.md

GET_PUBKEY is used in your wallet already. During the "Import Account" the wallet polls the Ledger app for the first 5 addresses (or more if requested). This view is the result of that interaction:

Screenshot_2023-06-08_at_3 24 38_PM

He is requesting an additional button in your wallet (after import) that will use VERIFY_ADDRESS instead. The difference between the two is that the "verify" version prompts the user after displaying the address on the device. I suggest this new button replace "Export Keyfile" shown here as it is unused/non-functional: Image

Screenshot_2023-06-08_at_3 24 58_PM

Log Out on Top Right Corner

This button is non-functional

PseudoMera commented 1 year ago

Fixed in #feat: update ledger