pokt-network / wallet

A simple web wallet to handle your Pocket Network accounts.
wallet-three-orpin.vercel.app
MIT License
8 stars 14 forks source link

Staging #426

Closed PseudoMera closed 1 year ago

height[bot] commented 1 year ago

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

πŸ’‘Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

πŸ”Ž Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960836) | Basic Auth String | 00376d314942844a4b3eb6339bc0831949f9d921 | .github/workflows/staging.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/00376d314942844a4b3eb6339bc0831949f9d921#diff-7bb7a67ed05f3845ed1f1b92dc4b87dfb0dd9aba208cca5489055ccef315117bR46) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960835) | Basic Auth String | 00376d314942844a4b3eb6339bc0831949f9d921 | .github/workflows/testnet.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/00376d314942844a4b3eb6339bc0831949f9d921#diff-53527a71bb5d87df90c56bcf05cebcb5999db913e197b5046b4b38524200ac74R49) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960873) | Basic Auth String | adcf4e24d6550cb2ea1600e530d50b62ba77c406 | .github/workflows/staging.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/adcf4e24d6550cb2ea1600e530d50b62ba77c406#diff-7bb7a67ed05f3845ed1f1b92dc4b87dfb0dd9aba208cca5489055ccef315117bR46) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960872) | Basic Auth String | adcf4e24d6550cb2ea1600e530d50b62ba77c406 | .github/workflows/testnet.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/adcf4e24d6550cb2ea1600e530d50b62ba77c406#diff-53527a71bb5d87df90c56bcf05cebcb5999db913e197b5046b4b38524200ac74R49) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960994) | Basic Auth String | 7d1ed63592cf16ae5a40e597bab1a2817f802ee0 | .github/workflows/staging.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/7d1ed63592cf16ae5a40e597bab1a2817f802ee0#diff-7bb7a67ed05f3845ed1f1b92dc4b87dfb0dd9aba208cca5489055ccef315117bL46) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960995) | Basic Auth String | 7d1ed63592cf16ae5a40e597bab1a2817f802ee0 | .github/workflows/testnet.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/7d1ed63592cf16ae5a40e597bab1a2817f802ee0#diff-53527a71bb5d87df90c56bcf05cebcb5999db913e197b5046b4b38524200ac74L49) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960996) | Basic Auth String | 95b45a6c47b4190a9106ab46c6a3c8e0f54231ea | .github/workflows/staging.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/95b45a6c47b4190a9106ab46c6a3c8e0f54231ea#diff-7bb7a67ed05f3845ed1f1b92dc4b87dfb0dd9aba208cca5489055ccef315117bL46) | | [5304277](https://dashboard.gitguardian.com/incidents/5304277?occurrence=95960997) | Basic Auth String | 95b45a6c47b4190a9106ab46c6a3c8e0f54231ea | .github/workflows/testnet.yml | [View secret](https://github.com/pokt-foundation/wallet/commit/95b45a6c47b4190a9106ab46c6a3c8e0f54231ea#diff-53527a71bb5d87df90c56bcf05cebcb5999db913e197b5046b4b38524200ac74L49) |
πŸ›  Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/basic_auth_string#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

πŸ¦‰ GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
wallet βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jun 12, 2023 3:54pm