Fix and upgrade test suite

roydejong commented 5 years ago

When running yarn test on Windows 10 x64, with Node v10.15.3, the current version of node-pcsclite produces the following error:

TypeError: stub(obj, 'meth', fn) has been removed, see documentation

This causes all tests to fail on my system. This is related to a deprecation / API change in Sinon: https://github.com/sinonjs/sinon/issues/1761#issuecomment-386034296

Some other things I've noticed:

The "start" and "connect" tests fail due to a timeout (they seem to be incomplete).
There is a Buffer deprecation warning (as of Node v10).
Mocha seems to hang after running the tests instead of exiting cleanly.

This PR addresses issues with the test suite by:

Applying sinon-codemod/extract-calls-fake to test.js.
Upgrading the sinon dependency in package.json to ^7.3.2 (latest release).
Updating the new Buffer() calls to Buffer.from().
Rewriting the "#start()" test so it makes sense, with sample data based on the example in pcsc.js.
Modifying the get_reader() test helper so it uses the correct end marker for reader names (fixes the "#connect()" test).
Tests: Add explicit done() calls all round to ensure the tests actually complete as expected.

roydejong commented 5 years ago

It took a bit of work, but this PR is in a state where all the tests now pass successfully on my system, and everything works as expected.

There's still a bug where mocha doesn't exit on its own. It seems PCSCLite.close() isn't enough to shut everything down cleanly, but I'm not sure how to deal with that. Maybe someone else knows. (Note, it is possible to force mocha to exit anyway after tests with --exit flag)

pokusew commented 4 years ago

Hi @roydejong,

Thank you very much for your PR. I really appreciate the work you did. 👍

I am really sorry it look me so long to review and merge it.

Thanks again.

pokusew / node-pcsclite

Fix and upgrade test suite #25