search

pola-rs / polars-cli

CLI interface for running SQL queries with Polars as backend
https://pola.rs/
MIT License
160 stars 12 forks source link

Why are binaries not available? #6

Closed zeritonius closed 1 year ago

zeritonius commented 1 year ago

Description

Until binaries are available, the only way to install the Polars CLI is by building it from source

If I make Windows binaries on my computer, can I submit them as a PR? Or is it a license problem with distributing the exe files created by Rust?

I don't want to sound disrespectful, but if you already built the binaries on your computer, why not publish them as a release? What am I missing, please?

Thank you.

ritchie46 commented 1 year ago

We must setup CI to automatically build binaries for many OS architectures and CPU targets. We don't upload binaries built on our local machines.

You are free helping setting up CI. As to why, because there are just so many hours in a day.

zeritonius commented 1 year ago

Thank you so much for your detailed explanation! Now it makes perfect sense to me. The missing part for me was the "automatically build".

I'm new to CI, but I'd like to help. Could you, please, give me some hints of where to start? Or, an existing repository that has CI, from which I can learn and adapt it to this one?

Thank you.

ethack commented 1 year ago

@zeritonius this looks like a fairly recent decent example.

FWIW, I wasn't able to get it to build with cargo +nightly install --locked polars-cli. It failed with this error: 

error[E0635]: unknown feature `proc_macro_span_shrink`

I had to clone locally and use cargo install --locked --path . and that worked. I think the former was not picking up the toolchain requirement.

stinodego commented 1 year ago

I am like 80% of the way there to setting up the CI, but I have been busy with the new 0.19 Polars release. Now that it's released, I can finish the CI here.

stinodego commented 1 year ago

(Some) binaries are available as assets in the latest GitHub release!