Open mcrumiller opened 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 81.33%. Comparing base (
42795c6
) to head (e717464
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@alexander-beedie thanks, working on parametrizing and indeed running into cases where we're outside the Datetime casting ability, but I'm not sure how to deal with it. It looks like Date.cast(Datetime)
fails (may open an issue) in general (@MarcoGorelli) (opened #16039):
from datetime import date
import polars as pl
pl.Series([date(1677, 9, 22)]).cast(pl.Datetime("ns")) # 1677-09-22 00:00:00
pl.Series([date(1677, 9, 21)]).cast(pl.Datetime("ns")) # 2262-04-11 23:34:33.709551616
@alexander-beedie fixed up a few things and expanded the tests. Let me know if you think it needs more testing or changes.
I restricted the times in the test to be within the Date -> Nanosecond allowance, as that can be addressed in the other issue I opened.
Sorry, let this one sit; can you rebase/update and I'll take another look :)
@alexander-beedie should be good once tests complete.
Fixes #16012.