search

pola-rs / polars

Dataframes powered by a multithreaded, vectorized query engine, written in Rust
https://docs.pola.rs
Other
26.63k stars 1.63k forks source link

feat: Move diagonal & horizontal concat schema resolving to IR phase #16034

Closed ritchie46 closed 2 weeks ago

ritchie46 commented 2 weeks ago

This also make diagonal concat faster as we did mutliple with_columns sequentially. Now they are batched.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 96.25000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.91%. Comparing base (222216a) to head (0f4f5ec). Report is 2 commits behind head on main.

:exclamation: Current head 0f4f5ec differs from pull request most recent head 92e48d0. Consider uploading reports for the commit 92e48d0 to get more accurate results

Files Patch % Lines
py-polars/src/lazyframe/visitor/nodes.rs 0.00% 2 Missing :warning:
...-plan/src/logical_plan/conversion/convert_utils.rs 98.36% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16034 +/- ## ======================================= Coverage 80.91% 80.91% ======================================= Files 1385 1385 Lines 178244 178229 -15 Branches 3050 3050 ======================================= - Hits 144229 144218 -11 + Misses 33526 33521 -5 - Partials 489 490 +1 ``` | [Flag](https://app.codecov.io/gh/pola-rs/polars/pull/16034/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/pola-rs/polars/pull/16034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | `74.39% <96.25%> (-0.01%)` | :arrow_down: | | [rust](https://app.codecov.io/gh/pola-rs/polars/pull/16034/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | `78.13% <96.25%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.