pola-rs / polars

Dataframes powered by a multithreaded, vectorized query engine, written in Rust
https://docs.pola.rs
Other
26.63k stars 1.63k forks source link

feat: Support non-coalescing joins in default engine #16036

Closed ritchie46 closed 2 weeks ago

ritchie46 commented 2 weeks ago

closes #14925

Left join still coalesces by default. Would need a breaking release to change the default.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.92%. Comparing base (a3dedb1) to head (a181627). Report is 4 commits behind head on main.

Files Patch % Lines
.../polars-lazy/src/physical_plan/streaming/checks.rs 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16036 +/- ## ======================================= Coverage 80.92% 80.92% ======================================= Files 1385 1385 Lines 178242 178233 -9 Branches 3050 3050 ======================================= - Hits 144234 144228 -6 + Misses 33520 33516 -4 - Partials 488 489 +1 ``` | [Flag](https://app.codecov.io/gh/pola-rs/polars/pull/16036/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/pola-rs/polars/pull/16036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | `74.40% <88.23%> (+<0.01%)` | :arrow_up: | | [rust](https://app.codecov.io/gh/pola-rs/polars/pull/16036/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | `78.13% <94.11%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 2 weeks ago

CodSpeed Performance Report

Merging #16036 will improve performances by 33.88%

Comparing join (a181627) with main (5da378f)

Summary

⚡ 1 improvements ✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main join Change
test_filter2 2.8 ms 2.1 ms +33.88%