pola-rs / polars

Dataframes powered by a multithreaded, vectorized query engine, written in Rust
https://docs.pola.rs
Other
26.63k stars 1.63k forks source link

fix: Fix casting decimal to decimal for high precision #16049

Closed stinodego closed 1 week ago

stinodego commented 1 week ago

Closes https://github.com/pola-rs/polars/issues/16027

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.96%. Comparing base (e17ef46) to head (4dbd338).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16049 +/- ## ========================================== - Coverage 80.96% 80.96% -0.01% ========================================== Files 1386 1386 Lines 178385 178383 -2 Branches 3060 3060 ========================================== - Hits 144438 144431 -7 - Misses 33460 33465 +5 Partials 487 487 ``` | [Flag](https://app.codecov.io/gh/pola-rs/polars/pull/16049/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | Coverage Δ | | |---|---|---| | [python](https://app.codecov.io/gh/pola-rs/polars/pull/16049/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | `74.50% <100.00%> (-0.03%)` | :arrow_down: | | [rust](https://app.codecov.io/gh/pola-rs/polars/pull/16049/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs) | `78.14% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pola-rs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codspeed-hq[bot] commented 1 week ago

CodSpeed Performance Report

Merging #16049 will improve performances by 24.72%

Comparing fix-decimal-cast (4dbd338) with main (e17ef46)

Summary

⚡ 1 improvements ✅ 34 untouched benchmarks

Benchmarks breakdown

Benchmark main fix-decimal-cast Change
test_filter2 2.8 ms 2.2 ms +24.72%