Closed nameexhaustion closed 1 month ago
Attention: Patch coverage is 95.65217%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 80.87%. Comparing base (
d7d720a
) to head (1112d3f
).
Files | Patch % | Lines |
---|---|---|
crates/polars-io/src/csv/read/reader.rs | 83.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I like this because it shortens the name, and hides mmap as an implementation detail
Yeap, agree. :+1:
Removes code that was previously disabled by https://github.com/pola-rs/polars/pull/16231
BatchedCsvReaderRead
BatchedCsvReaderMmap -> BatchedCsvReader
,fn batched_mmap -> fn batched
etc.mmap
as an implementation detail