pola-rs / polars

Dataframes powered by a multithreaded, vectorized query engine, written in Rust
https://docs.pola.rs
Other
27.24k stars 1.67k forks source link

feat(python): Enable generating data with time zones in parametric testing #16298

Closed stinodego closed 4 weeks ago

stinodego commented 1 month ago

Changes

Note that I'm avoiding the Datetime(time_zone="*") notation here because it's problematic in a number of ways. Instantiated data types should represent one specific data type, not match a whole bunch of data types. Unfortunately that does mean we have no good way to enable/disable time zones using allowed_dtypes/excluded_dtypes parameters, so I'm going with a separate parameter for this one.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.78%. Comparing base (11fe9d8) to head (748dade). Report is 12 commits behind head on main.

Files Patch % Lines
...olars/polars/testing/parametric/strategies/data.py 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16298 +/- ## ========================================== - Coverage 80.80% 80.78% -0.02% ========================================== Files 1393 1393 Lines 179406 179375 -31 Branches 2921 2925 +4 ========================================== - Hits 144971 144917 -54 - Misses 33932 33955 +23 Partials 503 503 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.