search

pola-rs / polars

Dataframes powered by a multithreaded, vectorized query engine, written in Rust
https://docs.pola.rs
Other
26.9k stars 1.65k forks source link

perf: do not use pyo3-built #16309

Closed orlp closed 1 week ago

orlp commented 2 weeks ago

This crate only saved us ~50 LOC and included a hidden dependency on email.utils increasing our import times.

While in the process I also renamed the awkwardly named pl.build_info()["build"] to pl.build_info()["compiler"] and pl.build_info()["info-time"] is now a RFC2822 string pl.build_info()["time"].

ritchie46 commented 2 weeks ago

I guess this is technically a breaking change.. 🤔

We have many more places where we don't regard anything about the exact output. E.g. explain, serialization, describe. This can join that list.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.33%. Comparing base (b61a5a9) to head (49e051e). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16309 +/- ## ========================================== + Coverage 80.76% 81.33% +0.57% ========================================== Files 1393 1403 +10 Lines 179416 183333 +3917 Branches 2921 2924 +3 ========================================== + Hits 144910 149121 +4211 + Misses 34003 33709 -294 Partials 503 503 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.