Open mcrumiller opened 2 weeks ago
@alexander-beedie
Hmm... might want to bring it to the attention of the ADBC folks too, since presumably it'll affect all client connections/data (eg: non-polars callers uploading pyarrow
, etc) 🤔
might want to bring it to the attention of the ADBC folks too
I'm writing up an issue for them, but figured we should have a workaround in the meantime.
I'm writing up an issue for them, but figured we should have a workaround in the meantime.
Looks like they're moving to fix this - better that than applying a workaround on our side. Let's see if it makes their next release 👌
@alexander-beedie I think we may want to at least put in a version check along with a warning telling the user to upcast, or do an automatic upcast ourselves based on adbc version. Their Milestone 14 isn't due until mid-Aug. Not that that's super far away, but polars moves quickly :)
Checks
Reproducible example
Here is a check that goes through all of the basic (non-nested) dtypes:
Log output
Due to:
Issue description
df.write_database(...)
fails for certain dtypes because adbc does not support those types. We should probably upcast where possible, e.g. u8 -> i16, u16 -> i32, u64 -> i64 if possible, warn if overflow.Installed versions
main