Open jvdd opened 5 days ago
Attention: Patch coverage is 17.54386%
with 94 lines
in your changes missing coverage. Please review.
Project coverage is 79.47%. Comparing base (
414d883
) to head (f98b8fc
). Report is 37 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Performance optimization of
group_by_dynamic
when passing a vanillaint_range
(i.e., start=0, step=1) asindex_column
. If we know that the index column for the dynamic group by is an int range, we can generate the group indices (as there is a fixed step between the index values) and can thus avoid the slowgroup_by_windows
function.Any feedback to improve this PR is welcome :)
Further enhancements (that could? be done):
Using the updated code, I observe ~10x performance improvements on my machine