search

pola-rs / pyo3-polars

Plugins/extension for Polars
MIT License
232 stars 38 forks source link

Implement FromPyObject and IntoPy Traits for AnyValue #37

Open JabobKrauskopf opened 10 months ago

JabobKrauskopf commented 10 months ago

I added a new PyAnyValue wrapper around AnyValue and implemented the FromPyObject, IntoPy, From and AsRef traits for the new wrapper

Any feedback is welcome!

See issues: #10

I hope we can get this merged! :D

JabobKrauskopf commented 10 months ago

I saw that both unwrap and expect were used in the rest of the library. Let me know if you have any preferences and if I should improve the error handling for PyAnyValue

FloLimebit commented 9 months ago

This feature would be super helpful - is there any update on the PR already? :)

JabobKrauskopf commented 6 months ago

@ritchie46 Thanks for the review and yeah it makes total sense to copy the implementation from py-polars. I tried to copy everything that is needed but need help in some parts that I'll mention in other comments. I'm still very new to rust so I still find it a bit difficult finding my way around in a big project like polars, so any help is appreciated :)

P.S.: Thank you for your amazing work on polars. It's been a huge factor in wanting to learn rust