search

pola-rs / pyo3-polars

Plugins/extension for Polars
MIT License
238 stars 39 forks source link

New polars version broke this wrapper #5

Closed SimonG85 closed 1 year ago

SimonG85 commented 1 year ago

With the release 0.27 of polars this crate has been broken.

In particular, the function into() that allows to transform a PyDataFrame into a polars DataFrame is broken.

The compiler says: "the trait bound polars::prelude::DataFrame: From<PyDataFrame> is not satisfied the trait From<&polars::prelude::Schema> is implemented for polars::prelude::DataFrame required for PyDataFrame to implement Into<polars::prelude::DataFrame>"

With 0.26 version of polars it works perfectly.

I have checked and also the example is broken.

ritchie46 commented 1 year ago

Right. We need to update the polars dependency.

SimonG85 commented 1 year ago

Can I help you? I tried to compile by myself but I found several problems in many places.

ritchie46 commented 1 year ago

Yes, the cargo.toml needs to be updated.

SimonG85 commented 1 year ago

Ok, I updated the toml file but also the exception had to be updated. I made (my first) pr with those updates.

ritchie46 commented 1 year ago

Published.