search

pola-rs / r-polars

Bring polars to R
https://pola-rs.github.io/r-polars/
Other
398 stars 35 forks source link

Prevent unnamed non-`Field` elements in `pl$Struct()` #1053

Open etiennebacher opened 3 weeks ago

etiennebacher commented 3 weeks ago

Close #1011

Breaking so should be in 0.17.0

etiennebacher commented 1 week ago

@eitsupi do you think the next release will be 0.16.4 or 0.17.0? Just wondering since I have a couple of PR that can be merged if the next one is 0.17

eitsupi commented 1 week ago

I am also worried about this....... The next release of Rust Polars seems going to be pretty huge, and considering that Python was not even released last week, I think we may have trouble incorporating Rust Polars' breaking changes here. So I think it would be better to merge in potentially breaking changes like this and #1078, but probably rarely used, and release 0.16.4. (If we follow semantic versioning, all releases prior to 1.0.0 may contain braking changes, so it is acceptable for 0.16.4 to contain breaking changes)

etiennebacher commented 1 week ago

I don't think the next rust-polars release will be a big issue (I mean I don't see why it would be more problematic than the previous ones). Also, this PR and #1050 shouldn't have many conflicts with the next release of rust-polars so I'm fine with waiting the rust-polars update before merging those.

eitsupi commented 1 week ago

Since #1078 is no longer a breaking change, I would like to merge #1078 and release 0.16.4.

etiennebacher commented 1 week ago

Ah sorry, I understood that you would like to merge this PR but I just misread, back to draft