pola-rs / r-polars

Polars R binding
https://pola-rs.github.io/r-polars/
Other
473 stars 35 forks source link

Can't compile anymore: ``#![feature]` may not be used on the stable release channel` #222

Closed etiennebacher closed 1 year ago

etiennebacher commented 1 year ago

make docs used to work flawlessly but I now have an error (rextendr::document() fails the same way):

 error[E0554]: `#![feature]` may not be used on the stable release channel
     --> C:\Users\etienne\.cargo\registry\src\github.com-1ecc6299db9ec823\argminmax-0.6.1\src\lib.rs:72:39
      |
   72 | #![cfg_attr(feature = "nightly_simd", feature(stdsimd))]
      |                                       ^^^^^^^^^^^^^^^^

   error[E0554]: `#![feature]` may not be used on the stable release channel
     --> C:\Users\etienne\.cargo\registry\src\github.com-1ecc6299db9ec823\argminmax-0.6.1\src\lib.rs:73:39
      |
   73 | #![cfg_attr(feature = "nightly_simd", feature(avx512_target_feature))]
      |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

   error[E0554]: `#![feature]` may not be used on the stable release channel
     --> C:\Users\etienne\.cargo\registry\src\github.com-1ecc6299db9ec823\argminmax-0.6.1\src\lib.rs:74:39
      |
   74 | #![cfg_attr(feature = "nightly_simd", feature(arm_target_feature))]
      |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^

   error[E0554]: `#![feature]` may not be used on the stable release channel
     --> C:\Users\etienne\.cargo\registry\src\github.com-1ecc6299db9ec823\argminmax-0.6.1\src\lib.rs:72:47
      |
   72 | #![cfg_attr(feature = "nightly_simd", feature(stdsimd))]
      |                                               ^^^^^^^

Here's what I have:

>rustup --version
rustup 1.26.0 (5af9b9484 2023-04-05)
info: This is the version for the rustup toolchain manager, not the rustc compiler.
info: The currently active `rustc` version is `rustc 1.69.0 (84c898d65 2023-04-16)`

I also ran rextendr::clean()+ document() but it didn't change anything. How can I fix that?

eitsupi commented 1 year ago

I think this is due to the Rust toolchain version. See #217

https://github.com/pola-rs/r-polars/blob/10dd2a68ee67223c4f767d3a30d68dec71b583f8/Makefile#L6

etiennebacher commented 1 year ago

I did this:

rustup toolchain install nightly-2023-04-11
rustup override set nightly-2023-04-11
rustup target add x86_64-pc-windows-gnu

and it looks like it worked

sorhawell commented 1 year ago

@etiennebacher Sry for slow answer.

The following make should ideally give you the official workable rust version for nightly: make requirement-rs

...and for stable: make requirements-rs-universe

For stable the Cargo.toml file is also modified

etiennebacher commented 1 year ago

I see, thanks (and no worries)