search

polac24 / InjectionTDD

Live unit tests for TDD using injectionForXcode
MIT License
41 stars 2 forks source link

Xcode10 incompatibility with InjectionIII #13

Closed polac24 closed 5 years ago

polac24 commented 5 years ago

When trying to use InjectionTDD with InjectionIII installed on Xcode10, simulator for XR such error logs to a console:

2018-10-28 22:34:35.378827+0100 InjectionTDD[72019:5332216] Error loading /Applications/InjectionIII.app/Contents/Resources/tvOSInjection.bundle/tvOSInjection:  dlopen(/Applications/InjectionIII.app/Contents/Resources/tvOSInjection.bundle/tvOSInjection, 265): no suitable image found.  Did find:
    /Applications/InjectionIII.app/Contents/Resources/tvOSInjection.bundle/tvOSInjection: mach-o, but not built for iOS simulator
2018-10-28 22:34:35.379020+0100 InjectionTDD[72019:5332216] Warning: Injection for Xcode not found. Please open Injection For Xcode.
zenangst commented 5 years ago

Hey @polac24, because we don't have ABI stability in Swift yet, we need to create two different bundles, one for Xcode 9 and one for Xcode 10. To use InjectionIII with Xcode 10 you should load the following bundle:

Bundle(path: "/Applications/InjectionIII.app/Contents/Resources/iOSInjection10.bundle")?.load()

We have updated the README to include these instructions - https://github.com/johnno1962/InjectionIII

polac24 commented 5 years ago

Sure, the fact that InjectionTDD loads tvOS bundle(note error message) when trying to work on iphone’s simulator, is a bug. I didn’t have time to investigate why during review it worked well but after a merge I still get such error. On Mon, 29 Oct 2018 at 07:22, Christoffer Winterkvist < notifications@github.com> wrote:

Hey @polac24 https://github.com/polac24, because we don't have ABI stability in Swift yet, we need to create two different bundles, one for Xcode 9 and one for Xcode 10. To use InjectionIII with Xcode 10 you should load the following bundle:

Bundle(path: "/Applications/InjectionIII.app/Contents/Resources/iOSInjection10.bundle")?.load()

We have updated the README to include these instructions - https://github.com/johnno1962/InjectionIII

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/polac24/InjectionTDD/issues/13#issuecomment-433800167, or mute the thread https://github.com/notifications/unsubscribe-auth/AJLu6cRKFIVHT4FQgClcPccbULifwkO4ks5upp6rgaJpZM4X-MoB .

zenangst commented 5 years ago

@polac24 I can probably take a look at it and make a PR :) I think we need to revise the preprocessors. I'll keep you posted!

zenangst commented 5 years ago

@polac24 I made a PR for you :)