search

polachok / netmap-rs

Higher level interface to netmap
3 stars 2 forks source link

iterator improvements #6

Closed rbtcollins closed 8 years ago

rbtcollins commented 8 years ago

This is in a branch to not muddy the discussion on my earlier pending PR, may be a bit ugly to review until that is merged.

rbtcollins commented 8 years ago

Ping? I've been using this for a bit and it seems ok so far; I'd like your thoughts on it. The mutation of received packets is pretty important for my use case, and I can break that out separately if the other stuff is contentious or whatever.

rbtcollins commented 8 years ago

ping again :)

polachok commented 8 years ago

I'll accept that, but I think in future we should drop the Iterator trait, because this implementation doesn't conform to 'Iterator laws', i.e. .zip() doesn't work as one expects, and so on. It's confusing for the user.