search

polarbeardesign / dds_app

2nd Gen
2 stars 0 forks source link

Fixing duplicate member add bug #14

Closed bryancross closed 6 years ago

bryancross commented 7 years ago

Added check for nil current_user in app/views/members/_form.html.erb

Also added .idea to .gitignore, because I'm lame and use an IDE.

Added comments to Gemfile to indicate which changes were necessary for bundle install to run to completion on my Mac. many of these Gems seem to be out of date....

Fixes #13

polarbeardesign commented 6 years ago

It was a bit more involved than your edit... I had co-opted the member admin form - which has a role assignment section, which only admins and superusers can assign.

I removed that role assignment for the member 'application' - as they shouldn't set their role and they don't have permission/role assigned yet anyway since they are new.

The real issue was on a form validation error the app loaded the original admin form, not the 'application' form. So I modified the controller, on 'application' form validation error, to go back to the 'application' form (without the roles assignment form - so no error for not having an assigned role).