polarbearzoo / maidsafe-dht

Automatically exported from code.google.com/p/maidsafe-dht
0 stars 0 forks source link

CMakeLists.txt: error finding protobuf #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Platform: Ubuntu 9.10 (Karmic)

maidsafe-dht: revision 354

Problem:

CMake failed to generate build files for the project because it reports that 
it failed to find libprotobuf runtime library (CMakeLists.txt lines 314--
320).

Suggestion:

I notice that you are making use of custom FIND_PATH and FIND_LIBRARY 
macros and specifically checking for libprotobuf.a (CMakeLists.txt line 
310), while I only have shared libraries installed via the standard Debian 
binary package. CMake is successful, and so is the entire project build 
process, if I substitute libprotobuf.a with libprotobuf.so in CMakeLists.txt. 
So I do not think that you intended to only use the static version of the 
library.

CMake version 2.8 provides the FIND_PACKAGE macro for locating and 
initializing the paths and files for Protobuf. Any reason you are not making 
use of this?

Keep up the good work!

Thanks!
Amit

Original issue reported on code.google.com by amit.ram...@gmail.com on 17 Feb 2010 at 8:05

GoogleCodeExporter commented 9 years ago
Thanks Amit, my bad I have committed this and should not have (I added the .a) 
as I 
was looking at some issues with static libs. We will take a look at the 
protobuf find 
in 2.8. I think there was some issues the guys noted but it does make sense. 
Thanks for the support
David

Original comment by irvine.d...@gmail.com on 17 Feb 2010 at 9:02

GoogleCodeExporter commented 9 years ago
HI Amit I am merging this now as Jose is redoing the cmake list to fix the 
included 
protobuf files in the repository. We will now check for updated .proto files 
and rerun 
the compiler if necessary.

Original comment by irvine.d...@gmail.com on 18 Feb 2010 at 8:15

GoogleCodeExporter commented 9 years ago
Yep, makes sense. Thanks!

Original comment by amit.ram...@gmail.com on 19 Feb 2010 at 5:19