search

polarbearzoo / maidsafe-dht

Automatically exported from code.google.com/p/maidsafe-dht
0 stars 0 forks source link

protobuf derived files in repository #8

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Platform: using Ubuntu 9.10 (but following issue applies to any platform)

maidsafe-dht: revision 354

Issue:

The .pb.cc and .pb.h files derived from .proto files (in src/protobuf) using 
protoc 
are checked into the repository. I have version 2.0.3 of  protobuf installed 
(from 
the latest package) and so the build process fails because of inconsistency 
with 
the checked in version of derived files (I assume version 2.1). However, if I 
delete 
all the protobuf derived files and regenerate them using my installed protoc 
compiler then the build process completes successfully and everything is good.

Suggestion:

Is there any reason why these derived files have been checked in? Shouldn't 
they 
be generated as part of the build process? 

Of course I use version 2.0.3, while you recommend 2.1. But it builds and works 
fine for me nonetheless. Given that they are derived files I would expect them 
to 
be part of the build process.

Regards
Amit

Original issue reported on code.google.com by amit.ram...@gmail.com on 18 Feb 2010 at 6:26

GoogleCodeExporter commented 9 years ago 
Hi Amit,
At the moment I am working on the cmake file to make the generation of the 
.pb.cc 
and .pb.h files part of the build process.
Also, I am improving the way we where finding the libraries (protobuf, boost, 
gtest, 
etc) and adding the option to add the path to the libraries if they are not 
installed in default directories (/usr/ and /usr/local in linux) and to make 
the 
file more readable.
When I commit these changes I will also remove from the repositories the .pb.cc 
and .pb.h files.

Cheers,
Jose

Original comment by jacisner...@googlemail.com on 18 Feb 2010 at 11:06

GoogleCodeExporter commented 9 years ago 
Issue 7 has been merged into this issue.

Original comment by irvine.d...@gmail.com on 18 Feb 2010 at 8:15

GoogleCodeExporter commented 9 years ago 
That's great! Look forward to the next revision.

Cheers
Amit

Original comment by amit.ram...@gmail.com on 19 Feb 2010 at 5:22

GoogleCodeExporter commented 9 years ago 
It has been tested on Linux, OSX and Windows (MinGW).
Commit 355 and 357.

Original comment by jacisner...@googlemail.com on 19 Feb 2010 at 2:32

GoogleCodeExporter commented 9 years ago 
Jose,

    Just tried it out on my system, builds beautifully :)!

Thanks!
Amit

Original comment by amit.ram...@gmail.com on 22 Feb 2010 at 8:03