polaris-sc2 / polaris-training

For code etc relating to the network training process.
Apache License 2.0
12 stars 2 forks source link

Initialize continuous integration with Travis CI #1

Closed kiudee closed 5 years ago

kiudee commented 5 years ago

Description

To get the ball rolling with properly tested pull requests, this pull requests sets up Travis CI. It will set up a basic Miniconda installation, retrieve all necessary packages and run all tests.

Discussion points:

inoryy commented 5 years ago

What's the benefit of Apache license over MIT?
And :+1: from me on Travis CI.

Matuiss2 commented 5 years ago

I always advocate for very permissive licenses like MIT, but Apache is better for this project since it will receive a lot of contributors. This link explains it very well https://exygy.com/which-license-should-i-use-mit-vs-apache-vs-gpl/

kiudee commented 5 years ago

How can we persuade Travis to succeed, if there are no tests?

islamelnabarawy commented 5 years ago

From that link:

  • The MIT, BSD, and ISC licenses are “permissive licenses”. They are extremely short and essentially say “do whatever you want with this, just don’t sue me.”
  • The Apache license says “do whatever you want with this, just don’t sue me” but does so with many more words, which lawyers like because it adds specificity. It also contains a patent license and retaliation clause which is designed to prevent patents (including patent trolls) from encumbering the software project.
Lambdanaut commented 5 years ago

I'm seeing an error with the create_env script on my macbook

install_miniconda.sh worked fine, and it looks like running it this second time confirms it, but create_env complains that I don't have it installed.

Administrators-MacBook-Pro-2:leelastar-training jthomas$ sudo sh scripts/install_miniconda.sh 
Miniconda already installed at /Users/jthomas/miniconda3.  Updating, adding to path and exiting
Adding /Users/jthomas/miniconda3 to PATH.  Consider adding it in your .rc file as well.
Collecting package metadata: ...working... done
Solving environment: ...working... done

# All requested packages already installed.

Administrators-MacBook-Pro-2:leelastar-training jthomas$ sh scripts/create_testenv.sh 
+ command -v conda
+ echo 'Requires conda but it is not installed.  Run install_miniconda.sh.'
Requires conda but it is not installed.  Run install_miniconda.sh.
+ exit 1

Can someone else test to see if it works?

islamelnabarawy commented 5 years ago

@Lambdanaut Did you import conda into your bash session? You might need to source the right file for it to work.

inoryy commented 5 years ago

@Lambdanaut works for me on Ubuntu 18.04

Lambdanaut commented 5 years ago

Thanks guys. It installed to my home directory but didn't add that to my path, so I added it manually. Running now.

Lambdanaut commented 5 years ago

New to travis. How do I interact with travis.yml here? I installed travis using a package manager.