search

polarity-lang / polarity

A Language with Dependent Data and Codata Types
https://polarity-lang.github.io
Apache License 2.0
57 stars 2 forks source link

Add GitHub workflow for code coverage #372

Closed BinderDavid closed 4 days ago

BinderDavid commented 4 days ago

Fixes #365

I explicitly only run the coverage action on pushes to main, and not in Pull requests. My philosophy is that coverage should not be used as an acceptance criterion for PRs, but as a diagnostic that we can inspect and monitor as we see fit.

In order for this PR to work I still need to do some setup with codecov.io and the organisation settings.

BinderDavid commented 4 days ago

Also, with the free plan we have 0 of 250 uploads in the last 30 days. If we upload on every push to a PR we might exceed these limits. We are unlikely to merge more than 250 PRs in a month.

BinderDavid commented 4 days ago

The codecov.io and the App integration in the settings should be configured correctly. So we just have to try whether it works.

timsueberkrueb commented 4 days ago

For the purpose of testing this, would you mind temporarily enabling running codecov on this PR?

codecov[bot] commented 4 days ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

:information_source: You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered :open_umbrella:

BinderDavid commented 4 days ago

Ok, maybe we can try it like this, and disable checks on PRs later if the bot messages bother us too much?

timsueberkrueb commented 4 days ago

I think you're looking at the wrong pricing plan. There's unlimited uploads for public open-source repos (source: https://about.codecov.io/pricing/).

BinderDavid commented 4 days ago

Please ensure we're using the correct open source plan for codecov. If so, I think we're good, thank you!

Ah, the free plan is only limited to 250 uploads/month for private repos. I looked at the wrong spot.