polarofficial / polar-ble-sdk

Repository includes SDK and code examples. More info https://polar.com/en/developers
Other
475 stars 153 forks source link

iOS and Android SDK inconsistencies #329

Closed Rexios80 closed 1 year ago

Rexios80 commented 1 year ago

This isn't a bug, but an inconsistency between the iOS and Android SDKs in the latest 5.0.0-beta2.

iOS:

Screenshot 2023-02-13 at 12 56 56 PM

Android:

Screenshot 2023-02-13 at 12 57 10 PM

Ideally, these should be the same, and match the structure of the other streaming features data types

Rexios80 commented 1 year ago

Also shouldn't PolarHrSample have a timestamp field?

Rexios80 commented 1 year ago

Another inconsistency I've noticed is PolarOhrPpi related names

iOS:

Android:

I think these names would be more consistent considering the names of other features:

JOikarinen commented 1 year ago

Thanks for the feedback @Rexios80. Here is the PR of your suggestion #345

Rexios80 commented 1 year ago

Closing. Thanks for fixing this.