polarofficial / polar-ble-sdk

Repository includes SDK and code examples. More info https://polar.com/en/developers
Other
449 stars 147 forks source link

Calling `getAvailableOnlineStreamDataTypes` throws `PolarBleSdk.PolarErrors.notificationNotEnabled` with the H9 #359

Open Rexios80 opened 1 year ago

Rexios80 commented 1 year ago

Platform on which you observed the bug:

Device on which you observed the bug:

Describe the bug Getting PolarBleSdk.PolarErrors.notificationNotEnabled when calling getAvailableOnlineStreamDataTypes

This is confirmed working for the H10 and Verity

How to Reproduce Call getAvailableOnlineStreamDataTypes for a Polar H9

Expected behavior It works like with the H10 and Verity

Screenshots and logs

Screenshot 2023-04-07 at 11 39 31 AM

Additional Information Not sure how useful this is, but here's the code for the plugin: https://github.com/Rexios80/polar The example app in that repo can reproduce the issue

This is with SDK 5.0.2

samulimaa commented 1 year ago

Hi, getAvailableOnlineStreamDataTypes is part of the Polar Online Streaming API which is only supported by Verity Sense, H10 and OH1 devices. But I think that the thrown error could be improved to reveal the actual cause.

Rexios80 commented 1 year ago

That makes sense, except heart rate is part of streaming now which is why I expect that call to not fail on any device that supports heart rate streaming. I would expect getAvailableOnlineStreamDataTypes to return heart rate on every Polar device. I suppose I can just assume that heart rate is available, but it's still weird.

Rexios80 commented 1 year ago

Also, sdkFeatureReady is returning onlineStreaming when connected to the H9. I'm waiting for that to even make the getAvailableOnlineStreamDataTypes call

Screenshot 2023-04-19 at 6 29 11 AM
Rexios80 commented 1 year ago

@samulimaa Is a fix for this planned?

Rexios80 commented 10 months ago

@samulimaa This seems like it would be trivial to fix. Should we except a solution for this soon or work around it?

Rexios80 commented 3 weeks ago

@palmqvisti Sorry for the ping but I see you have recent activity in this repo so you got picked. Can you or someone else please either provide a status update or close this issue as not planned?