search

polarsignals / frostdb

❄️ Coolest database around 🧊 Embeddable column database written in Go.
Apache License 2.0
1.29k stars 65 forks source link

pqarrow/builder: Add OptFloat64Builder #823

Closed metalmatze closed 4 months ago

metalmatze commented 4 months ago

We mostly need this because it supports the Set and Add methods compared to the upstream Float64Builder.

metalmatze commented 4 months ago

Agreed on the generic tests. :+1: I was already thinking the same when I posted the PR. I'll see what I can easily come up with before we merge this one.

metalmatze commented 4 months ago

I'm going to merge this as the generic tests have been added. Let me know if we need to follow up on anything.

asubiotto commented 4 months ago

Thanks!